On Fri, Apr 30, 2021 at 3:22 AM Andy Shevchenko
[off-list ref] wrote:

On Fri, Apr 30, 2021 at 1:34 AM Raul E Rangel [off-list ref] wrote:

quoted

This allows the OS to control which devices produce wake events.

$ grep enabled /sys/kernel/irq/*/wakeup
/sys/kernel/irq/24/wakeup:enabled

Is it a bug fix of [1]?

If so, add a BugLink: tag here.

No bug, just implementing a missing feature. This allows the use of
the ACPI _AEI object.

quoted

Signed-off-by: Raul E Rangel <redacted>

[1]:

...

irq_hw_number_t hw = irqd_to_hwirq(d);

quoted

+       pin_reg = readl(gpio_dev->base + (d->hwirq)*4);

quoted

+       writel(pin_reg, gpio_dev->base + (d->hwirq)*4);

Too many parentheses and missed spaces

I copy/pasted the exact format used in all the other functions:
amd_gpio_irq_{enable,disable,mask,unmask}. I can send a CL to reformat
everything if you want. Or I can just change this specific function.
Let me know.

--
With Best Regards,
Andy Shevchenko

Thanks for the review!