Re: [PATCH v1 1/1] gpiolib: Drop duplicate offset check in gpiochip_is_requested()
From: Bartosz Golaszewski <hidden>
Date: 2021-05-21 12:54:06
Also in:
lkml
From: Bartosz Golaszewski <hidden>
Date: 2021-05-21 12:54:06
Also in:
lkml
On Mon, May 10, 2021 at 9:52 PM Andy Shevchenko [off-list ref] wrote:
gpiochip_get_desc() already does the check, drop a duplicate in gpiochip_is_requested(). Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpiolib.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 1427c1be749b..220a9d8dd4e3 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c@@ -2004,9 +2004,6 @@ const char *gpiochip_is_requested(struct gpio_chip *gc, unsigned int offset) { struct gpio_desc *desc; - if (offset >= gc->ngpio) - return NULL; - desc = gpiochip_get_desc(gc, offset); if (IS_ERR(desc)) return NULL; --2.30.2
I applied this some time ago just forgot to comment here. Bart