Re: [PATCH] Signed-off-by: Michael Estner <michaelestner@web.de>
From: Linus Walleij <hidden>
Date: 2021-03-01 09:05:44
Hi Michael! Thanks for your patch! Make sure to send patches to the linux-gpio list and Bartosz as well. On Fri, Feb 19, 2021 at 6:46 PM Michael Estner [off-list ref] wrote:
quoted hunk
Delete unused else if iteration. --- drivers/gpio/gpiolib.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 97eec8d8dbdc..1fe38fc99b8f 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c@@ -612,9 +612,6 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, dev_set_drvdata(&gdev->dev, gdev); if (gc->parent && gc->parent->driver) gdev->owner = gc->parent->driver->owner; - else if (gc->owner) - /* TODO: remove chip->owner */ - gdev->owner = gc->owner;
As long as we have not resolved the TODO I think this needs to stay around. What makes you think this is not needed anymore? Yours, Linus Walleij