Hi Linus,

-----Original Message-----
From: Linus Walleij <redacted>
Sent: Thursday, March 25, 2021 2:27 PM
To: Sai Krishna Potthuri <redacted>
Cc: Andy Shevchenko <redacted>; Rob Herring
[off-list ref]; Michal Simek [off-list ref]; Greg Kroah-
Hartman [off-list ref]; linux-arm Mailing List <linux-arm-
kernel@lists.infradead.org>; Linux Kernel Mailing List <linux-
kernel@vger.kernel.org>; devicetree [off-list ref]; open
list:GPIO SUBSYSTEM [off-list ref]; git [off-list ref];
saikrishna12468@gmail.com
Subject: Re: [PATCH v4 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support

On Mon, Mar 22, 2021 at 4:25 PM Sai Krishna Potthuri
[off-list ref] wrote:

quoted

[Andy]

quoted

quoted

quoted

quoted

quoted

+       PIN_CONFIG_IOSTANDARD = PIN_CONFIG_END + 1, };

I'm lost here. What is IO standard exactly? Why it can't be in
generic headers?

It represents LVCMOS 3.3 volts/ LVCMOS 1.8 volts.
Since this is specific to Xilinx ZynqMP platform, considered to be
added in the driver file.

So, why can't we create a couple of bits to represent this voltages
in the generic header and gain usability for others as well?

I see some drivers are maintaining the configuration list in the
driver file, if the configuration is specific to the driver.

We can move this to generic header if it is used by others as well.
Ok, will wait for Linus to comment.

quoted

Linus?

While it is fine to add custom pin config options to pin controllers for
hopelessly idiomatic stuff, this does look like it should be using
PIN_CONFIG_POWER_SOURCE with the voltage rail as parameter, see
include/linux/pinctrl/pinconf-generic.h

Thanks.
I will update the driver to use 'power-source' option.

Regards
Sai Krishna

If you're not using that then tell us why.

Yours,
Linus Walleij