Re: [PATCH v4 09/16] gpio: support ROHM BD71815 GPOs

From
Linus Walleij <hidden>
Date
2021-03-25 09:36:35
Also in
linux-devicetree, lkml
Reply to
Matti Vaittinen, 2021-03-24
On Wed, Mar 24, 2021 at 8:29 AM Matti Vaittinen
[off-list ref] wrote:
Support GPO(s) found from ROHM BD71815 power management IC. The IC has two
GPO pins but only one is properly documented in data-sheet. The driver
exposes by default only the documented GPO. The second GPO is connected to
E5 pin and is marked as GND in data-sheet. Control for this undocumented
pin can be enabled using a special DT property.

This driver is derived from work by Peter Yang [off-list ref]
although not so much of original is left.

Signed-off-by: Matti Vaittinen <redacted>
---
Changes since v3:
  - No changes
This looks OK to me:
Acked-by: Linus Walleij <redacted>

It could potentially (like the other Rohm GPIO MFD PMIC drivers)
make some use of the gpio regmap library, but we have some
pending changes for that so look into it after the next merge
window.

I.e. for your TODO: look at the GPIO_REGMAP helper.

Yours,
Linus Walleij
Thread (19 messages) 19 messages, 4 authors, last reply 2021-05-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help