Re: [PATCH v2 2/2] intel/pinctrl: check capability offset is between MMIO region

[PATCH v2 0/2] intel/pinctrl: check some registers reads · Roger Pau Monne <roger.pau@citrix.com> · 2021-03-24
[PATCH v2 2/2] intel/pinctrl: check capability offset is between MMIO region · Roger Pau Monne <roger.pau@citrix.com> · 2021-03-24
Re: [PATCH v2 2/2] intel/pinctrl: check capability offset is between MMIO region · Andy Shevchenko <hidden> · 2021-03-24
[PATCH v2 1/2] intel/pinctrl: check REVID register value for device presence · Roger Pau Monne <roger.pau@citrix.com> · 2021-03-24
Re: [PATCH v2 1/2] intel/pinctrl: check REVID register value for device presence · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-03-24
Re: [PATCH v2 1/2] intel/pinctrl: check REVID register value for device presence · Roger Pau Monné <roger.pau@citrix.com> · 2021-03-25

From: Andy Shevchenko <hidden>
Date: 2021-03-24 17:03:12
Also in: lkml, xen-devel

On Wed, Mar 24, 2021 at 04:43:12PM +0100, Roger Pau Monne wrote:

When parsing the capability list make sure the offset is between the
MMIO region mapped in 'regs', or else the kernel hits a page fault.

Adding the check is harmless, and prevents buggy or broken systems
from crashing the kernel if the capability linked list is somehow
broken.

I don't think we need a dead code in the kernel. If you have a hardware to show
this issue, I eagerly want to know this!

-- 
With Best Regards,
Andy Shevchenko

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help