Hi Andy,

On Friday, March 19, 2021 6:32 PM, Andy Shevchenko wrote:

On Fri, Mar 19, 2021 at 10:10 AM Ran Wang [off-list ref] wrote:

quoted

Current implementation only supports DT, now add ACPI support.

Thanks for an update, my comments below.

...

quoted

+#include <linux/acpi.h>

Missed
property.h
mod_devicetable.h.

Got it.
 

...

quoted

-       mpc8xxx_gc->regs = of_iomap(np, 0);
+       mpc8xxx_gc->regs = devm_platform_ioremap_resource(pdev, 0);

quoted

        if (!mpc8xxx_gc->regs)

This is wrong now.

Yes, will correct this in next version

quoted

                return -ENOMEM;

This too.

Got it.
 

...

quoted

+       fwnode = dev_fwnode(&pdev->dev);
        if (of_device_is_compatible(np, "fsl,qoriq-gpio") ||
            of_device_is_compatible(np, "fsl,ls1028a-gpio") ||
-           of_device_is_compatible(np, "fsl,ls1088a-gpio"))
+           of_device_is_compatible(np, "fsl,ls1088a-gpio") ||

quoted

+           !(IS_ERR_OR_NULL(fwnode) || is_of_node(fwnode)))

Since you left acpi.h inclusion, you may switch this to

is_acpi_node(fwnode)

or drop fwnode and use

has_acpi_companion(&pdev->dev)

OK, will use is_acpi_node(fwnode) instead (since fwnode is referred in following irq_domain_create_linear()

Thanks for your patient educate :)

Regards,
Ran