Thread (5 messages) 5 messages, 4 authors, 2021-03-10

Re: [PATCH] pinctrl: qcom: lpass lpi: use default pullup/strength values

From: Linus Walleij <hidden>
Date: 2021-03-10 23:14:51
Also in: linux-arm-msm, lkml

On Thu, Mar 4, 2021 at 8:49 PM Jonathan Marek [off-list ref] wrote:
If these fields are not set in dts, the driver will use these variables
uninitialized to set the fields. Not only will it set garbage values for
these fields, but it can overflow into other fields and break those.

In the current sm8250 dts, the dmic01 entries do not have a pullup setting,
and might not work without this change.

Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver")
Signed-off-by: Jonathan Marek <redacted>
Patch applied for fixes!

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help