On Mon, Mar 08, 2021 at 08:43:19PM +0100, Rafael J. Wysocki wrote:

On Mon, Mar 8, 2021 at 8:33 PM Andy Shevchenko
[off-list ref] wrote:

...

It looks like the ops local var is redundant.

quoted

        unsigned int type;
        unsigned int i;

@@ -1496,11 +1496,7 @@ static int gpiochip_add_irqchip(struct gpio_chip *gc,
                        return ret;
        } else {
                /* Some drivers provide custom irqdomain ops */
-               if (gc->irq.domain_ops)
-                       ops = gc->irq.domain_ops;
-
-               if (!ops)
-                       ops = &gpiochip_domain_ops;
+               ops = gc->irq.domain_ops ?: &gpiochip_domain_ops;
                gc->irq.domain = irq_domain_create_simple(fwnode,
                        gc->ngpio,
                        gc->irq.first,

Because this can be

gc->irq.domain = irq_domain_add_simple(np,
                        gc->ngpio,
                        gc->irq.first,
                        gc->irq.domain_ops ?: &gpiochip_domain_ops,
                        gc);

(modulo white space / formatting) and this is the only place where ops
is used in this function.

I just sent v5 without this, sorry :-)

-- 
With Best Regards,
Andy Shevchenko