Andy,
On Thu, 04 Mar 2021 15:02:11 +0000,
Andy Shevchenko [off-list ref] wrote:
Linus Walleij pointed out that ird_domain_add_simple() gained
additional functionality and can't be anymore replaced with
a simple conditional. In preparation to upgrade GPIO library
to use fwnode, introduce irq_domain_create_simple() API which is
functional equivalent to the existing irq_domain_add_simple(),
but takes a pointer to the struct fwnode_handle as a parameter.
While at it, amend documentation to mention irq_domain_create_*()
functions where it makes sense.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
[...]
quoted hunk ↗ jump to hunk
diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
index 42d196805f58..1d4a8e7c5d5f 100644
--- a/include/linux/irqdomain.h
+++ b/include/linux/irqdomain.h
@@ -265,6 +265,11 @@ struct irq_domain *irq_domain_add_simple(struct device_node *of_node,
unsigned int first_irq,
const struct irq_domain_ops *ops,
void *host_data);
+struct irq_domain *irq_domain_create_simple(struct fwnode_handle *fwnode,
+ unsigned int size,
+ unsigned int first_irq,
+ const struct irq_domain_ops *ops,
+ void *host_data);
struct irq_domain *irq_domain_add_legacy(struct device_node *of_node,
unsigned int size,
unsigned int first_irq,
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 288151393a06..418548ea13cf 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -317,10 +317,20 @@ struct irq_domain *irq_domain_add_simple(struct device_node *of_node,
unsigned int first_irq,
const struct irq_domain_ops *ops,
void *host_data)
+{
+ return irq_domain_create_simple(of_node_to_fwnode(of_node), size, first_irq, ops, host_data);
+}
+EXPORT_SYMBOL_GPL(irq_domain_add_simple);
Please move this as an inline helper in linux/irqdomain.h, so that we
can drop this export altogether.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.