Thread (2 messages) 2 messages, 2 authors, 2021-03-02

Re: [PATCH v1] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB

From: Linus Walleij <hidden>
Date: 2021-03-02 19:49:13
Also in: linux-arm-msm, lkml

On Thu, Feb 25, 2021 at 9:33 AM Julian Braha [off-list ref] wrote:
When PINCTRL_MSM is enabled, and GPIOLIB is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
  Depends on [n]: GPIOLIB [=n]
  Selected by [y]:
  - PINCTRL_MSM [=y] && PINCTRL [=y] && (ARCH_QCOM || COMPILE_TEST [=y])

This is because PINCTRL_MSM selects GPIOLIB_IRQCHIP,
without selecting or depending on GPIOLIB, despite
GPIOLIB_IRQCHIP depending on GPIOLIB. Having PINCTRL_MSM
select GPIOLIB will cause a recursive dependency error.

Signed-off-by: Julian Braha <redacted>
Does it work to just:

select GPIOLIB

instead?

The driver needs the library so...

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help