Re: [PATCH 03/12] Documentation: add BCM6358 pincontroller binding documentation
From: Linus Walleij <hidden>
Date: 2021-03-02 19:46:02
Also in:
linux-devicetree, lkml
On Thu, Feb 25, 2021 at 5:42 PM Álvaro Fernández Rojas [off-list ref] wrote:
Add binding documentation for the pincontrol core found in BCM6358 SoCs. Signed-off-by: Álvaro Fernández Rojas <redacted> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
(...)
quoted hunk ↗ jump to hunk
+ interrupts-extended: + description: + One interrupt per each of the 4 GPIO ports supported by the controller,
4? Below says 6.
quoted hunk ↗ jump to hunk
+ sorted by port number ascending order. + minItems: 6 + maxItems: 6
As noted in the review I think this interrupt controller is hierarchical and this is not needed. All that is needed is for the chip to know its interrupt-parent. Yours, Linus Walleij