On Thu, Feb 04, 2021 at 10:43:49AM +0100, Bartosz Golaszewski wrote:

On Thu, Feb 4, 2021 at 2:19 AM Kent Gibson [off-list ref] wrote:

quoted

On Wed, Feb 03, 2021 at 01:23:25PM +0100, Bartosz Golaszewski wrote:

quoted

From: Bartosz Golaszewski <redacted>

Add the LICENSES directory as suggested by Greg KH. It will contain the
license files relevant to this project that is: LGPL-2.1 for the library
and GPL-2.0 & the Linux-syscall-note for the Linux Kernel uAPI header.

Signed-off-by: Bartosz Golaszewski <redacted>

I see you are following the kernel licencing rules wrt license file
naming and formatting.
Have you considered following the REUSE spec, as Greg also suggested,
instead?

Cheers,
Kent.

The library is tightly coupled with the kernel so I thought it's best
to follow the same scheme. Every file also has an SPDX identifier so
together this looks clean to me.

Sure, but if following the REUSE spec would make life easier for projects
built on top of libgpiod then I'm all for it.

The existing SPDX headers are REUSE compliant so you are actually quite
close to REUSE compliance already, but ironically the license files
themselves, both before and after your changes, aren't.

Cheers,
Kent.