Re: [PATCH] gpio: gpiolib: remove shadowed variable
From: Bartosz Golaszewski <hidden>
Date: 2021-02-01 09:00:04
Also in:
linux-renesas-soc
From: Bartosz Golaszewski <hidden>
Date: 2021-02-01 09:00:04
Also in:
linux-renesas-soc
On Wed, Jan 27, 2021 at 11:39 AM Wolfram Sang [off-list ref] wrote:
On Tue, Jan 05, 2021 at 12:14:34PM +0100, Geert Uytterhoeven wrote:quoted
On Tue, Jan 5, 2021 at 12:00 PM Wolfram Sang [off-list ref] wrote:quoted
After refactoring, we had two variables for the same thing. Remove the second declaration, one is enough here. Found by cppcheck. drivers/gpio/gpiolib.c:2551:17: warning: Local variable 'ret' shadows outer variable [shadowVariable] Fixes: d377f56f34f5 ("gpio: gpiolib: Normalize return code variable name") Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>Ccing Linus & Bartosz
For some reason this is not on patchwork and I also don't have it in my inbox, can you resend, please? Bart