Thread (33 messages) 33 messages, 6 authors, 2021-03-05

Re: [PATCH] gpiolib: acpi: support override broken GPIO number in ACPI table

From: Andy Shevchenko <hidden>
Date: 2021-02-26 09:15:23
Also in: linux-acpi, linux-arm-msm

On Fri, Feb 26, 2021 at 5:42 AM Shawn Guo [off-list ref] wrote:
Running kernel with ACPI on Lenovo Flex 5G laptop, touchpad is just
not working.  That's because the GpioInt number of TSC2 node in ACPI
table is simply wrong, and the number even exceeds the maximum GPIO
lines.  As the touchpad works fine with Windows on the same machine,
presumably this is something Windows-ism.  Although it's obviously
a specification violation, believe of that Microsoft will fix this in
the near future is not really realistic.

It adds the support of overriding broken GPIO number in ACPI table
on particular machines, which are matched using DMI info.  Such
mechanism for fixing up broken firmware and ACPI table is not uncommon
in kernel.  And hopefully it can be useful for other machines that get
broken GPIO number coded in ACPI table.
Thanks for the report and patch.

First of all, have you reported the issue to Lenovo? At least they
will know that they did wrong.
Second, is it possible to have somewhere output of `acpidump -o
flex5g.dat` (the flex5g.dat file)?

And as Mika said once to one of mine patches "since you know the
number ahead there is no need to pollute GPIO ACPI library core with
this quirk". But in any case I would like to see the ACPI tables
first.

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help