Hi Andy, Laurent

On 24/02/2021 10:18, Andy Shevchenko wrote:

On Wed, Feb 24, 2021 at 12:16 PM Laurent Pinchart
[off-list ref] wrote:

quoted

On Tue, Feb 23, 2021 at 10:36:18PM +0000, Daniel Scally wrote:

quoted

On 23/02/2021 20:04, Laurent Pinchart wrote:

...

quoted

quoted

quoted

quoted

+  get_device(&int3472->sensor->dev);

I see no corresponding put_device(), am I missing something ? I'm also
not sure why this is needed.

The put is acpi_dev_put() in skl_int3472_discrete_remove(); there seems
to be no acpi_dev_get() for some reason. We use the sensor acpi_device
to get the clock frequency, and to fetch the sensor module string, so I
thought it ought to hold a reference on those grounds.

Shouldn't acpi_dev_get_dependent_dev() increase the reference count
then, instead of doing it manually here ?

That's what I expected as well.
We have plenty of acpi_dev_get_*() and they do increase the reference
counter one way or the other.

Okedokey, I'll move the get() to that function and drop it from here.