On Sun, Jan 31, 2021 at 1:43 AM Kent Gibson [off-list ref] wrote:

On Sat, Jan 30, 2021 at 09:37:55PM +0100, Bartosz Golaszewski wrote:

quoted

On Fri, Jan 29, 2021 at 4:57 PM Andy Shevchenko
[off-list ref] wrote:

quoted

On Fri, Jan 29, 2021 at 02:46:24PM +0100, Bartosz Golaszewski wrote:

quoted

From: Bartosz Golaszewski <redacted>

...

[snip]

quoted

quoted

Honestly, I don't like the idea of Yet Another (custom) Parser in the kernel.

Have you investigated existing parsers? We have cmdline.c, gpio-aggregator.c,
etc. Besides the fact of test cases which are absent here. And who knows what
we allow to be entered.

Yes, I looked all around the kernel to find something I could reuse
but failed to find anything useful for this particular purpose. If you
have something you could point me towards, I'm open to alternatives.

Once we agree on the form of the module, I'll port self-tests to using
it instead of gpio-mockup, so we'll have some tests in the tree.

Given the existing selftests focus on testing the gpio-mockup itself, it
would be more appropriate that you add separate tests for gpio-sim.

As an end user I'm interested in the concrete example of driving gpio-sim
that selftests would provide, so I'm looking forward to seeing that.

Cheers,
Kent.

Makes sense, I'll add tests in v2.

Bartosz