Thread (7 messages) 7 messages, 3 authors, 2021-01-26

Re: [PATCH v5 0/4] gpio: mvebu: pwm fixes and improvements

From: Bartosz Golaszewski <hidden>
Date: 2021-01-26 05:25:56
Also in: linux-arm-kernel, linux-pwm

On Wed, Jan 20, 2021 at 5:16 PM Baruch Siach [off-list ref] wrote:
This series adds a few related fixes to the pwm .apply and .get_state
callbacks.

The first patch was originally part of the series adding Armada 8K/7K pwm
support. I split it out to a separate series following review comments from
Uwe Kleine-König who spotted a few more issues. There is no dependency between
this and the Armada 8K/7K series.

v5:

  * Drop a patch applied to the gpio tree

  * Fix patch 4/4 description typo (Uwe)

  * Reduce the number of multiplications (Uwe)

  * Add spaces around '+' (Uwe)

  * Use '1ULL' instead of explicit cast to reduce verbosity

  * Add Linus' Reviewed-by tags to patches that are unchanged since v2

v4:

  * Take advantage of zero value being treated as 2^32 by hardware. Rewrite
    patch 5/5 (Uwe).

v3:

  * Improve patch 3/5 description (Uwe)

  * Add more Reviewed-by tags from Uwe

v2:

Address Uwe Kleine-König comments.

  * Improve patch 1/5 summary line

  * Add more information to patch 1/5 description

  * Add more information to patch 2/5 description

  * Don't round period/duty_cycle up in .apply (patch 3/5)

  * Expand the comment in path 5/5 based on RMK's analysis of hardware
    behaviour

  * Add Uwe's Reviewed-by tags

Baruch Siach (4):
  gpio: mvebu: improve pwm period calculation accuracy
  gpio: mvebu: make pwm .get_state closer to idempotent
  gpio: mvebu: don't limit pwm period/duty_cycle to UINT_MAX
  gpio: mvebu: improve handling of pwm zero on/off values

 drivers/gpio/gpio-mvebu.c | 47 +++++++++++++++++++++------------------
 1 file changed, 25 insertions(+), 22 deletions(-)

--
2.29.2
Series applied, thanks a lot for the improvements! And thanks to Uwe
and Russel for the reviews.

Bartosz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help