Re: [PATCH V4 5/5] gpio: gpio-xilinx: Add check if width exceeds 32
From: Linus Walleij <hidden>
Date: 2021-01-07 10:19:04
Also in:
linux-arm-kernel, lkml
On Wed, Jan 6, 2021 at 1:27 PM Srinivas Neeli [off-list ref] wrote:
Add check to see if gpio-width property does not exceed 32. If it exceeds then return -EINVAL. Signed-off-by: Srinivas Neeli <redacted>
Aha
quoted hunk ↗ jump to hunk
@@ -591,6 +591,9 @@ static int xgpio_probe(struct platform_device *pdev) if (of_property_read_u32(np, "xlnx,gpio-width", &chip->gpio_width[0])) chip->gpio_width[0] = 32;
This xlnx,gpio-width seems very much like the standard ngpios property from Documentation/devicetree/bindings/gpio/gpio.txt but I guess not much to do about that now. :/ Do you think you can add support for both?
+ if (chip->gpio_width[0] > 32) + return -EINVAL;
This looks OK. Yours, Linus Walleij