On Tue, Oct 13, 2020 at 7:34 PM Kent Gibson [off-list ref] wrote:
On Tue, Oct 13, 2020 at 03:21:47PM +0200, Linus Walleij wrote:
quoted
On Thu, Oct 8, 2020 at 5:46 PM Bartosz Golaszewski
[off-list ref] wrote:
...
quoted
I am waiting for Kent to respin them addressing Andy's comments
on patch 5/5 then they can go in as fixes I think.
I had replied to Andy's comments - I'm prefer with my version than his
suggestion:
"I'm not keen on that alternative as what it suggests is actually a
pointer comparison, and even if the user realizes that they may instead
use "strlen(label) == 0", when they shouldn't be assuming that a null
terminator is present in the array. I avoided mentioning "string" and
kept it in terms of the char array for the same reason."
My point is to make documentation less cryptic (= less programming
language stylish).
If you can rephrase it that way - nice! Otherwise, I leave this to Linus.
--
With Best Regards,
Andy Shevchenko