Re: [PATCH v4 3/4] pinctrl: sh-pfc: align driver description title
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2020-08-31 14:08:51
Also in:
linux-renesas-soc
Hi Morimoto-san, On Mon, Aug 24, 2020 at 7:49 AM Kuninori Morimoto [off-list ref] wrote:
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Now, Renesas Pin Control drivers are under menu,
but current description are not aligned.
This patch align these.
- Emma Mobile EV2 pin control support
- R-Mobile APE6 pin control support
- R-Mobile A1 pin control support
- RZ/N1 pin control support
- RZ/G1H pin control support
- RZ/G1M pin control support
+ pin control support for Emma Mobile EV2
+ pin control support for R-Mobile APE6
+ pin control support for R-Mobile A1
+ pin control support for RZ/N1
+ pin control support for RZ/G1H
+ pin control support for RZ/G1M
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>quoted hunk ↗ jump to hunk
--- a/drivers/pinctrl/sh-pfc/Kconfig +++ b/drivers/pinctrl/sh-pfc/Kconfig@@ -56,7 +56,7 @@ config PINCTRL_SH_PFC This enables pin control drivers for Renesas SuperH and ARM platforms config PINCTRL_RZA1 - bool "RZ/A1 gpio and pinctrl driver" + bool "gpio and pinctrl driver for RZ/A1"
Do you mind if I change this to "pinctrl support for RZ/A1" (and fix up the sorting in 4/4), or do you insist on keeping the separation between "gpio and pinctrl" and "pure" pinctrl drivers? In reality, all SH, SH-Mobile, and R-Mobile pinctrl drivers are GPIO controller drivers, too, but this is currently no reflected by their description.
quoted hunk ↗ jump to hunk
depends on OF depends on ARCH_R7S72100 || COMPILE_TEST select GPIOLIB@@ -67,7 +67,7 @@ config PINCTRL_RZA1 This selects pinctrl driver for Renesas RZ/A1 platforms. config PINCTRL_RZA2 - bool "RZ/A2 gpio and pinctrl driver" + bool "gpio and pinctrl driver for RZ/A2"
Likewise.
depends on OF
depends on ARCH_R7S9210 || COMPILE_TEST
select GPIOLIB
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds