Re: [PATCH v1 1/3] pinctrl: intel: Extract intel_pinctrl_get_soc_data() helper for wider use
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2020-08-18 13:47:43
On Tue, Aug 18, 2020 at 03:36:02PM +0300, Mika Westerberg wrote:
On Tue, Aug 18, 2020 at 03:34:59PM +0300, Andy Shevchenko wrote:quoted
On Mon, Aug 03, 2020 at 04:50:31PM +0300, Andy Shevchenko wrote:quoted
On Mon, Aug 03, 2020 at 03:33:18PM +0300, Mika Westerberg wrote:quoted
On Wed, Jul 29, 2020 at 02:57:06PM +0300, Andy Shevchenko wrote:quoted
intel_pinctrl_get_soc_data() helper can be used in few driver instead of open-coded variants. Thus, extract it as a standalone API....quoted
quoted
+const struct intel_pinctrl_soc_data *intel_pinctrl_get_soc_data(struct platform_device *pdev)Can we make this take const parameter as well?You mean const struct intel_pinctrl_soc_data * intel_pinctrl_get_soc_data(const struct platform_device *pdev) ? Sure, I can do it for v2.Actually I can't. device_match_data() requires struct device * pointer and compiler is unable to compile with const qualifier.OKquoted
Are you good with current version then?Yes :)
Pushed to my review and testing queue, thanks! P.S. I have added your Ack as discussed offline. -- With Best Regards, Andy Shevchenko