Thread (6 messages) 6 messages, 5 authors, 2020-08-20

Re: [PATCH] gpio: omap: improve coding style for pin config flags

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: 2020-08-19 11:30:07
Also in: linux-omap, lkml


On 22/07/2020 15:07, Drew Fustini wrote:
quoted hunk ↗ jump to hunk
Change the handling of pin config flags from if/else to switch
statement to make the code more readable and cleaner.

Suggested-by: Gustavo A. R. Silva <redacted>
Signed-off-by: Drew Fustini <redacted>
---
  drivers/gpio/gpio-omap.c | 13 +++++++++----
  1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index e0eada82178c..7fbe0c9e1fc1 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -899,13 +899,18 @@ static int omap_gpio_set_config(struct gpio_chip *chip, unsigned offset,
  	u32 debounce;
  	int ret = -ENOTSUPP;
  
-	if ((pinconf_to_config_param(config) == PIN_CONFIG_BIAS_DISABLE) ||
-	    (pinconf_to_config_param(config) == PIN_CONFIG_BIAS_PULL_UP) ||
-	    (pinconf_to_config_param(config) == PIN_CONFIG_BIAS_PULL_DOWN)) {
+	switch (pinconf_to_config_param(config)) {
+	case PIN_CONFIG_BIAS_DISABLE:
+	case PIN_CONFIG_BIAS_PULL_UP:
+	case PIN_CONFIG_BIAS_PULL_DOWN:
  		ret = gpiochip_generic_config(chip, offset, config);
-	} else if (pinconf_to_config_param(config) == PIN_CONFIG_INPUT_DEBOUNCE) {
+		break;
+	case PIN_CONFIG_INPUT_DEBOUNCE:
  		debounce = pinconf_to_config_argument(config);
  		ret = omap_gpio_debounce(chip, offset, debounce);
+		break;
+	default:
+		break;
  	}
  
  	return ret;
Thank you.
Acked-by: Grygorii Strashko <grygorii.strashko@ti.com>

-- 
Best regards,
grygorii
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help