Hi Rob, Andreas,

Thanks for the review.

-----Original Message-----
From: Andreas Färber <afaerber@suse.de>
Sent: Tuesday, August 18, 2020 6:12 PM
To: Rob Herring <robh@kernel.org>; TY_Chang[張子逸]
[off-list ref]
Cc: linux-realtek-soc@lists.infradead.org; linux-gpio@vger.kernel.org;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; robh+dt@kernel.org;
linus.walleij@linaro.org
Subject: Re: [PATCH v3 5/9] dt-bindings: pinctrl: realtek: Add Realtek DHC SoC
rtd1295

Am 17.08.20 um 22:33 schrieb Rob Herring:

quoted

On Thu, 13 Aug 2020 15:49:04 +0800, TY Chang wrote:

quoted

Add device tree binding Documentation for rtd1295 pinctrl driver.

Signed-off-by: TY Chang <redacted>
---
 .../pinctrl/realtek,rtd1295-pinctrl.yaml      | 192 ++++++++++++++++++
 1 file changed, 192 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/pinctrl/realtek,rtd1295-pinctrl.yam
l

Please add Acked-by/Reviewed-by tags when posting new versions.
However, there's no need to repost patches *only* to add the tags. The
upstream maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.

The thing really missing here is a per-patch change log.

Things were added here that I'm sure you would not give your Reviewed-by for,
in particular new properties prefixed with unregistered rtk prefix instead of the
registered realtek prefix.

I will modify the property name with realtek prefix in patch v4.

@TY, hiding such changes in a big previously reviewed patch without any
mention is problematic - please rather do smaller follow-up patches to not
invalidate previous reviews with new features.

I'm sorry about that. I will add Reviewed-by tags in the previously reviewed patch and add follow-up patches for new features in patch v4.

Best Regards,
TYChang

 

------Please consider the environment before printing this e-mail.