Thread (6 messages) 6 messages, 3 authors, 2020-01-23

Re: [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency

From: Brendan Higgins <hidden>
Date: 2020-01-23 22:15:26
Also in: linux-um, lkml

Sorry for not getting to this before I went on vacation.

On Mon, Dec 16, 2019 at 2:39 AM Linus Walleij [off-list ref] wrote:
On Wed, Dec 11, 2019 at 8:28 PM Brendan Higgins
[off-list ref] wrote:
quoted
Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:

ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe':
drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency.

Reported-by: Brendan Higgins <redacted>
Signed-off-by: Brendan Higgins <redacted>
Patch applied but I augmented it with the recently added
OF dependency so it now says:
depends on OF && HAS_IOMEM
Probably too late now to be helpful, but I can confirm that OF does
NOT depend on HAS_IOMEM, so this patch was still needed.

Thanks regardless!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help