Thread (8 messages) 8 messages, 4 authors, 2018-09-14

Re: [PATCH] gpio: omap: Remove custom PM calls and use cpu_pm instead

From: Tony Lindgren <tony@atomide.com>
Date: 2018-09-11 23:28:05
Also in: linux-arm-kernel, linux-omap

* Ladislav Michl [off-list ref] [180911 19:44]:
Tony,

On Tue, Sep 11, 2018 at 11:37:29AM -0700, Tony Lindgren wrote:
quoted
For a long time the gpio-omap custom PM calls have been annoying me so
let's replace them with cpu_pm instead. This will enable GPIO PM for
deeper idle states on omap4. And we can handle GPIO PM for omap2/3/4
in the same way.

Note that with this patch we are also slightly changing GPIO PM to be
less aggressive for omap3 and only will idle GPIO when PER context
may be lost.
I do not think it will make things any worse, but will run my favorite
latency on test on this patch :)
Thanks I was hoping you'd do that :)
Meanwhile see nit bellow.
quoted
+	switch (cmd) {
+	case CPU_CLUSTER_PM_ENTER:
+		/* Gets cleard on runtime_suspend */
"Gets cleared" perhaps...
Thanks will fix and post v2 after waiting few days for
comments.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help