Thread (11 messages) 11 messages, 3 authors, 2018-09-27

Re: [PATCH 1/3] pinctrl: mcp23s08: fix debugfs entry for mcp23s18 device

From: Jan Kundrát <hidden>
Date: 2018-09-27 17:12:11
Also in: stable

On čtvrtek 27. září 2018 10:55:11 CEST, Marco Felsch wrote:
Hi Phil,

On 18-09-27 09:45, Phil Reid wrote:
quoted
On 26/09/2018 5:42 PM, Marco Felsch wrote:
quoted
On 18-09-26 07:55, Phil Reid wrote: ...
G'day Marco,

Sorry I still don't follow.
I've got a mcp23s18 in one of my systems and debugfs seems to work fine.

one_regmap_config is only used for the S08/S17 to fiddle with 
the name / label
I know, but if I read the code correctly it shouldn't work, because in
your case one_regmap_config is never modified, as you told. But it is
initialized to NULL. This confuses me a bit.

This tested should not be made for the MCP_TYPE_S18 case.
Ah, right. This means that the stable tree(s) need this follow-up patch 
from February, too:

  https://patchwork.ozlabs.org/patch/875045/

Thanks for catching this.

With kind regards,
Jan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help