Re: [PATCH v2] gpiolib: Defer on non-DT find_chip_by_name() failure
From: Boris Brezillon <hidden>
Date: 2018-07-04 07:17:30
Also in:
lkml
From: Boris Brezillon <hidden>
Date: 2018-07-04 07:17:30
Also in:
lkml
On Wed, 4 Jul 2018 00:18:19 +0200 Janusz Krzysztofik [off-list ref] wrote:
Avoid replication of error code conversion in non-DT GPIO consumers' code by returning -EPROBE_DEFER from gpiod_find() in case a chip identified by its label in a registered lookup table is not ready. See https://lkml.org/lkml/2018/5/30/176 for example case. Suggested-by: Boris Brezillon <redacted> Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com> Reviewed-by: Boris Brezillon <redacted> --- Changelog v2: fix typo (latar -> later) - thanks Boris and Andy for catching this I'm not sure if adding both Suggested-by: and Reviewed-by: heades both with the same person name is in line with good practices, please remove one if not.
I don't think that's a problem. Suggesting a solution and agreeing on the implementation are 2 different things, so both are not mutually exclusive IMO.