Re: pinctrl-amd: What hardware does it apply to?
From: Andrew Cooks <hidden>
Date: 2017-12-22 01:06:33
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2017-12-22 · Re: pinctrl-amd: What hardware does it apply to? · Christian Lamparter <hidden>
- 2017-12-22 · Re: pinctrl-amd: What hardware does it apply to? · Linus Walleij <hidden>
- 2017-12-22 · Re: pinctrl-amd: What hardware does it apply to? · Mika Westerberg <mika.westerberg@linux.intel.com>
- 2017-12-22 · Re: pinctrl-amd: What hardware does it apply to? · Andrew Cooks <hidden>
- 2017-12-22 · Re: pinctrl-amd: What hardware does it apply to? · Andrew Cooks <hidden>
Hi Tobias On 21/12/17 23:06, Tobias Diedrich wrote:
> Another driver (gpio-sb8xx) was submitted for upstream inclusion, but was
> knocked back with the suggestion that pinctrl is the way forward[3].
Hm I cannot follow link [3] right now. And I don't remember the submission :(
It doesn't seem to be in my mail archives either.
FWIW I wrote the gpio-sb8xx driver mostly to allow toggling the (board-specific) APU1 leds and didn't have time to rewrite it for the pinctrl api (also it was more of a "would be neat to have", so I didn't push it much).
It would actually be neat to have ACPI support for arbitrary leds in some better way (toggling the pinctrl bits could easily be implemented in ACPI if there was some method called to enabled/disable the led).>
The coreboot bits were submitted:
https://github.com/coreboot/coreboot/blob/master/src/mainboard/pcengines/apu1/acpi/leds.asl
https://github.com/coreboot/coreboot/blob/master/src/mainboard/pcengines/apu1/acpi/gpio.asl
The latter is specifically asking for "gpio-sb8xx" (or compatible) (this is essentially an ACPI-provided devicetree snippet).Our ACPI LED support is on a I2C GPIO expander, but looks similar. I'll submit that to coreboot after the holidays. We use the SoC gpios for buttons and other peripherals. a.