Re: [PATCH] gpio: syscon: do not use raw "set" callback in syscon_gpio_dir_out
From: Linus Walleij <hidden>
Date: 2017-09-21 11:23:45
I really need Alexander Shiyan to look at this patch. The way i percieve it, .set is NULL if the chip does not support output. We should print the right error messages and bail out if the user is anyway trying to set a line like that. Yours, Linus Walleij On Wed, Aug 30, 2017 at 4:50 PM, Vladimir Murzin [off-list ref] wrote:
quoted hunk ↗ jump to hunk
"set" callback is optional and can be NULL, instead use chip->set which always points at proper callback function. Fixes 2c341d62eb4b ("gpio: syscon: add soc specific callback to assign output value") Signed-off-by: Vladimir Murzin <redacted> --- drivers/gpio/gpio-syscon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c index 537cec7..cf88a0b 100644 --- a/drivers/gpio/gpio-syscon.c +++ b/drivers/gpio/gpio-syscon.c@@ -122,7 +122,7 @@ static int syscon_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int val) BIT(offs % SYSCON_REG_BITS)); } - priv->data->set(chip, offset, val); + chip->set(chip, offset, val); return 0; } --1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html