Re: [PATCH] pinctrl: sirf: atlas7: fix of_irq_get() error check

On Fri, Aug 4, 2017 at 6:58 PM, Sergei Shtylyov
[off-list ref] wrote:

On 08/04/2017 12:31 AM, Linus Walleij wrote:

quoted

quoted

of_irq_get() may return  any negative error number as well as 0 on
failure,
while the driver only checks for -EPROBE_DEFER, blithely continuing with
the call to gpiochip_set_chained_irqchip() -- that function expects the
parent IRQ as *unsigned int*, so would probably do nothing  when a large
IRQ number resulting from a conversion of a negative error number is
passed
to it, however passing 0 would probably work but the driver won't receive
valid GPIO bank interrupts.

Check for 'ret <= 0' instead and return -ENXIO from the driver's probe
iff
of_irq_get() returned 0.

Fixes: f9367793293d ("pinctrl: sirf: add sirf atlas7 pinctrl and gpio
support")
Signed-off-by: Sergei Shtylyov <redacted>

Patch applied!

  Thanks! But to which branch? I'm not seeing it in linux-pinctrl.git...

devel.

It seems the SiRF people are not using upstream (see other mails) so I do
not see we need to expediate it to fixes.

Yours,
Linus Walleij