Re: [PATCH v3] pinctrl: aspeed: Fix ast2500 strap register write logic
From: Andrew Jeffery <hidden>
Date: 2017-08-23 13:47:14
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 801 bytes
From: Andrew Jeffery <hidden>
Date: 2017-08-23 13:47:14
Also in:
lkml
On Wed, 2017-08-23 at 10:23 +0200, Linus Walleij wrote:
quoted
On Wed, Aug 23, 2017 at 1:54 AM, Andrew Jeffery [off-list ref] wrote: On Tue, 2017-08-22 at 14:52 +0200, Linus Walleij wrote:quoted
quoted
quoted
quoted
quoted
quoted
On Tue, Aug 15, 2017 at 6:21 PM, Yong Li [off-list ref] wrote:On AST2500, the hardware strap register(SCU70) only accepts write ‘1’, to clear it to ‘0’, must set bits(write ‘1’) to SCU7C Signed-off-by: Yong Li <redacted>Patch applied with Andrew's review/test tags.I realised after I sent the tags on v3 that I'd made a mistake: There's a slightly awkward to test bug in the v3 implementation. I followed up on v3 with this: https://lkml.org/lkml/2017/8/16/905 And Yong sent out a corresponding v4: https://patchwork.ozlabs.org/patch/802946/Ah. I got confused and picked the wrong version.
Entirely my fault. Apologies again for the confusion. I owe you a few drinks if we ever meet :)
quoted
I see you've pushed Yong's v3 in pinctrl/devel - can we revert/remove that and apply v4?No I would have to revert the patch. Can't we simply make a small fixup patch?
I couldn't recall what the rebase policy was for pinctrl/devel. I have sent the fixup patch: http://patchwork.ozlabs.org/patch/804981/ Cheers, Andrew
Yours, Linus Walleij