Re: [PATCH 1/2] pinctrl: qcom: disable GPIO groups with no pins

On Fri 14 Jul 10:01 PDT 2017, Timur Tabi wrote:

On 07/14/2017 11:44 AM, Bjorn Andersson wrote:

quoted

We would have to drop the "const" on the groups arrays of the other
platform in order to use this, but I don't have a better suggestion at
this time.

Why?  I don't modify any data in this patch, and I build just fine with
these options enabled:

CONFIG_PINCTRL_MSM8916=y
CONFIG_PINCTRL_MSM8994=y
CONFIG_PINCTRL_MSM8996=y
CONFIG_PINCTRL_QDF2XXX=m

What I mean is that if we want to specify that any pin of those drivers
are locked down we would make npins = 0.

But as this is a system configuration thing this information would
preferably be injected in runtime (like you do), but the
soc_data->groups arrays are currently all const (see e.g.
msm8x74_groups), so we can't change npins in runtime.


But I think this is fine for now.

Regards,
Bjorn