Re: [PATCH 5/8] gpio: exar: Fix reading of directions and values

On 2017-05-18 12:23, Andy Shevchenko wrote:

On Thu, May 18, 2017 at 1:16 PM, Jan Kiszka [off-list ref] wrote:

quoted

On 2017-05-18 12:11, Andy Shevchenko wrote:

quoted

On Thu, May 18, 2017 at 8:20 AM, Jan Kiszka [off-list ref] wrote:

quoted

quoted

Full picture:

 val = exar_get(chip, addr) & BIT(offset % 8);

 return !!val;

How it could be non-(1 or 0)?

Right - but what is the point of that other style?

gpio-exar.c is just 4th module which is using it, OTOH the rest of
GPIO drivers are using return !!val style.

OK, consistency is valid point. Will adjust.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux