Thread (5 messages) 5 messages, 3 authors, 2017-03-23

Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

From: Linus Walleij <hidden>
Date: 2017-03-14 15:04:50
Also in: linux-arm-kernel, linux-rockchip, lkml

On Thu, Mar 2, 2017 at 6:56 AM, Jeffy Chen [off-list ref] wrote:
Currently we are trying to enable/disable the clk of irq's gpio bank when
unmask/mask irq. But the kernel's "lazy disable approach" will skip masking
irq when the irq chip doesn't support irq_disable ops.

So we may hit this case:
        irq_enable-> enable clk
        irq_disable-> noop
        irq_enable-> enable clk again
        irq_disable-> noop

Signed-off-by: Jeffy Chen <redacted>
Heiko, can you look at this patch?

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help