On 29-09-16, 15:16, Vladimir Zapolskiy wrote:

If you look at the top I agree that this solution may be only one platform
specific, but it fixes the broken driver of i.MX I2C bus controller.

Yeah, I saw that..

Why do you get an impression that it looks like a hack?

Because we have to reorder things to make it work on a platform. This may break
things on other platforms and we don't know about it yet.

Why pinctrl_select_state() is not done in gpio_request_one()? Because
the first function gets pin mux/config setting and the second does not.
How do you intend to get pin mux/config setting in gpio_request_one()?

Lets see what Linus has to say on this..

Anyway I don't see any problems in pinctrl or gpio subsystems, the bugs
must be addressed and fixed in i2c.

I think it can be a gpio driver specific thing as well and not really subsystem
level one.

-- 
viresh