Thread (17 messages) flat view 17 messages, 2 authors, 2016-09-15

Re: [PATCH 8/8] gpio: don't include module.h in shared driver header

From: Linus Walleij <hidden>
Date: 2016-09-15 12:05:30
Also in: lkml

On Tue, Sep 13, 2016 at 12:16 AM, Paul Gortmaker
[off-list ref] wrote:
Most shared headers in include/linux don't need to know what the
internals of a struct module are; all they care about is that it
is a struct and hence they may require a pointer to one.

The advantage in this is that module.h is including a lot of stuff
itself, and an otherwise empty C file that just contains module.h
will result in ~750kB from CPP (compared to say 12kB from init.h)

So we have approximately 50 instances of "struct module;" in the
various include/linux headers already that help us keep module.h
out of other headers; here we do the same for gpio.

Cc: Linus Walleij <redacted>
Cc: Alexandre Courbot <redacted>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <redacted>
Probably my mistake.
Thanks for tidying this up so nicely!

Patch applied.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help