Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe
From: Phidias Chiang <hidden>
Date: 2016-09-12 06:56:42
Also in:
lkml
On Sun, Sep 11, 2016 at 11:05:06AM +0300, Mika Westerberg wrote:
quoted hunk ↗ jump to hunk
On Fri, Sep 09, 2016 at 11:58:32AM +0300, Mika Westerberg wrote:quoted
On Fri, Sep 09, 2016 at 04:23:58PM +0800, Phidias Chiang wrote: Only other place where we touch INTMASK register is chv_gpio_irq_mask_unmask(). Can you add some debug there to find out the caller?Something like this:diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c index 0fe8fad..95fa3b1 100644 --- a/drivers/pinctrl/intel/pinctrl-cherryview.c +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c@@ -1357,6 +1357,11 @@ static void chv_gpio_irq_mask_unmask(struct irq_data *d, bool mask) value |= BIT(intr_line); chv_writel(value, pctrl->regs + CHV_INTMASK); + if (printk_ratelimit()) { + dev_info(pctrl->dev, "%smask pin %u intmask 0x%08x\n", + mask ? "" : "un", pin, readl(pctrl->regs + CHV_INTMASK)); + } + raw_spin_unlock_irqrestore(&chv_lock, flags); }
With printk_ratelimit(): [ 2.058485] cherryview-pinctrl INT33FF:00: INTMASK0: 0x00000006 [ 2.058513] cherryview-pinctrl INT33FF:00: mask pin 0 intmask 0x00000006 [ 2.058533] cherryview-pinctrl INT33FF:00: mask pin 1 intmask 0x00000006 [ 2.058551] cherryview-pinctrl INT33FF:00: mask pin 2 intmask 0x00000006 [ 2.058569] cherryview-pinctrl INT33FF:00: mask pin 3 intmask 0x00000006 [ 2.058587] cherryview-pinctrl INT33FF:00: mask pin 4 intmask 0x00000006 [ 2.058604] cherryview-pinctrl INT33FF:00: mask pin 5 intmask 0x00000006 [ 2.058623] cherryview-pinctrl INT33FF:00: mask pin 6 intmask 0x00000006 [ 2.058641] cherryview-pinctrl INT33FF:00: mask pin 7 intmask 0x00000006 [ 2.058663] cherryview-pinctrl INT33FF:00: mask pin 15 intmask 0x00000006 [ 2.059401] cherryview-pinctrl INT33FF:00: INTMASK1: 0x00000000 [ 2.059551] cherryview-pinctrl INT33FF:01: INTMASK0: 0x00004000 [ 2.061272] cherryview-pinctrl INT33FF:01: INTMASK1: 0x00000000 [ 2.061516] cherryview-pinctrl INT33FF:02: INTMASK0: 0x00000000 [ 2.061906] cherryview-pinctrl INT33FF:02: INTMASK1: 0x00000000 [ 2.062116] cherryview-pinctrl INT33FF:03: INTMASK0: 0x00000000 [ 2.062956] cherryview-pinctrl INT33FF:03: INTMASK1: 0x00000000 w/o printk_ratelimit(): http://pastebin.com/dLDELDB4 The main difference is the intmask turns to 0x4 on pin 75 and 0x0 afterwards for INT33FF:00. And same thing happened with :01 on pin 25