Thread (10 messages) 10 messages, 3 authors, 2016-08-23

Re: [PATCH 3/4] gpio: spear-spics: drop unused MODULE_ tags from non-modular code

From: Masahiro Yamada <hidden>
Date: 2016-08-23 15:20:02
Also in: lkml

2016-08-23 1:48 GMT+09:00 Paul Gortmaker [off-list ref]:
quoted hunk ↗ jump to hunk
The Kconfig currently controlling compilation of this code is:

drivers/gpio/Kconfig:config GPIO_SPEAR_SPICS
drivers/gpio/Kconfig:   bool "ST SPEAr13xx SPI Chip Select as GPIO support"

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modular infrastructure use, so that
when reading the driver there is no doubt it is builtin-only.

We delete the MODULE_LICENSE tag etc. since all that information
is now contained at the top of the file in the comments.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

Cc: Linus Walleij <redacted>
Cc: Alexandre Courbot <redacted>
Cc: Shiraz Hashim <redacted>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <redacted>
---
 drivers/gpio/gpio-spear-spics.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpio/gpio-spear-spics.c b/drivers/gpio/gpio-spear-spics.c
index 7ffd16495286..22267479ba68 100644
--- a/drivers/gpio/gpio-spear-spics.c
+++ b/drivers/gpio/gpio-spear-spics.c
@@ -12,7 +12,7 @@
 #include <linux/err.h>
 #include <linux/gpio.h>
 #include <linux/io.h>
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/types.h>
Please keep the includes sorted alphabetically,
i.e. <linux/init.h> above <linux/io.h>.

I was a little late, though.



-- 
Best Regards
Masahiro Yamada
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help