Thread (24 messages) 24 messages, 4 authors, 2016-08-30

Re: [PATCH v2 8/8] gpio: Add Aspeed driver

From: Linus Walleij <hidden>
Date: 2016-08-22 13:48:40
Also in: linux-devicetree, lkml

On Fri, Aug 19, 2016 at 2:44 PM, Andrew Jeffery [off-list ref] wrote:
From: Joel Stanley <joel@jms.id.au>

The Aspeed SoCs contain GPIOs banked by letter, where each bank contains
8 pins. The GPIO banks are then grouped in sets of four in the register
layout.

The implementation exposes multiple banks through the one driver and
requests and releases pins via the pinctrl subsystem. The hardware
supports generation of interrupts from all GPIO-capable pins.

A number of hardware features are not yet supported: Configuration of
interrupt direction (ARM or LPC), debouncing, and WDT reset tolerance
for output ports.

Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Alistair Popple <redacted>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Andrew Jeffery <redacted>
This driver looks good now.

I guess I will have to wait for the rest to be fixed up
before applying.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help