Thread (3 messages) 3 messages, 2 authors, 2016-07-22

Re: [PATCH -next] pinctrl: fix build, PINCTRL_CYGNUS_MUX depends on OF

From: Ray Jui <hidden>
Date: 2016-07-22 18:09:30
Also in: linux-arm-kernel, linux-next, lkml

Hi Randy,

On 7/22/2016 11:06 AM, Randy Dunlap wrote:
quoted hunk ↗ jump to hunk
From: Randy Dunlap <redacted>

Fix pinctrl-cygnus-mux.c build when ARCH_BCM_CYGNUS is not enabled
but COMPILE_TEST is enabled by making the driver depend on OF.

../drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:739:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function)
  .dt_node_to_map = pinconf_generic_dt_node_to_map_group,

Signed-off-by: Randy Dunlap <redacted>
Cc: Ray Jui <rjui@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: Linus Walleij <redacted>
Cc: linux-gpio@vger.kernel.org
---
 drivers/pinctrl/bcm/Kconfig |    1 +
 1 file changed, 1 insertion(+)
--- linux-next-20160722.orig/drivers/pinctrl/bcm/Kconfig
+++ linux-next-20160722/drivers/pinctrl/bcm/Kconfig
@@ -60,6 +60,7 @@ config PINCTRL_IPROC_GPIO
 config PINCTRL_CYGNUS_MUX
 	bool "Broadcom Cygnus IOMUX driver"
 	depends on (ARCH_BCM_CYGNUS || COMPILE_TEST)
+	depends on OF
 	select PINMUX
 	select GENERIC_PINCONF
 	default ARCH_BCM_CYGNUS
Thanks, but a fix was already submitted by Arnd and picked up by Linus: 
https://lkml.org/lkml/2016/7/15/649

Ray
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help