On Wed, Jul 06, 2016 at 01:07:15PM +0300, Mika Westerberg wrote:

On Wed, Jul 06, 2016 at 10:57:19AM +0200, Linus Walleij wrote:

quoted

On Tue, Jun 28, 2016 at 1:56 AM, Bin Gao [off-list ref] wrote:

quoted

This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC.
This driver is based on gpio-crystalcove.c.

Signed-off-by: Ajay Thomas <redacted>
Signed-off-by: Bin Gao <redacted>
---
Changes in v4:
 - Converted CTLI_INTCNT_XX macros to less verbose ones INT_DETECT_XX.
 - Add comments about why there is no .pm for the driver.
 - Header files re-ordered.
 - Various coding style change to address Andy's comments.

Mika can I have your ACK/review tag on this driver so I can merge it?
I prefer to have all Intel stuff bearing your seal of approval.

Thanks for your trust :)

I don't have much comments in addition to what you already pointed out.
I'll just wait for the next revision and give my ack then.

quoted

quoted

+static irqreturn_t wcove_gpio_irq_handler(int irq, void *data)
+{
+       int pending;
+       unsigned int p0, p1, virq, gpio;
+       struct wcove_gpio *wg = data;

Bin,

Since you are going to make another iteration, please arrange the
declarations like:

	unsigned int p0, p1, virq, gpio;
	struct wcove_gpio *wg = data;
	int pending;

Yes, will do. Thanks.

-Bin