Re: [RFC] qnap-tsx51: add new driver for leds and button support on QNAP TS-x51 series

Hello,

On Fri, 17 Jun 2016 23:02:47 +0200, Linus Walleij
[off-list ref] wrote:

Well ask yourself what you are doing I guess, GPIO is
General Purpose Input Output, a trap some people fall into
is confusing that with their special purpose input/outputs,
and sometimes they are input-only or output-only on top of
that. That is not GPIO.

So what is the use case for these electronics? If it is not
supposed to be used by misc input/output, it is not GPIO,
and it is better for the driver to manage it at will.

Thanks, I think it is the distinction I did not do.

Just to confirm my understanding:
- from the chip (and its module) point of view, these signals are
  GPIOs, because they cannot presume how it is wired
- but from the platform point of view (this specific NAS model), these
  GPIOs are wired to leds and buttons, so they are leds and buttons
  and not GPIOs anymore

So using GPIO numbers is acceptable in such driver.

Is this correct ?
If it is, I will submit my patch on platform-drivers ML.

Regards,
-- 
Vincent Pelletier