Thread (3 messages) 3 messages, 3 authors, 2016-03-31

Re: [PATCH RFT] gpio: tpic2810: Make sure cached buffer has consistent status with h/w status

From: Alexandre Courbot <hidden>
Date: 2016-03-28 03:31:00

On Wed, Mar 23, 2016 at 8:49 PM, Axel Lin [off-list ref] wrote:
i2c_smbus_write_byte_data() can fail. To ensure the cached buffer has
consistent status with h/w status, don't update the cached gpio->buffer
if write fails.
Also refactor the code a bit by adding a tpic2810_set_mask_bits() helper
and use it to simplify the code.
Looks pretty good!

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help