Thread (71 messages) 71 messages, 10 authors, 2016-02-10

Re: [PATCH 3/6] gpio: add a userspace chardev ABI for GPIOs

From: Linus Walleij <hidden>
Date: 2016-01-28 11:13:29

On Sat, Oct 24, 2015 at 2:30 AM, Greg Kroah-Hartman
[off-list ref] wrote:
On Thu, Oct 22, 2015 at 10:32:27AM +0200, Linus Walleij wrote:
quoted
+/**
+ * struct gpiochip_info - Information about a certain GPIO chip
+ * @name: the name of this GPIO chip
+ * @lines: number of GPIO lines on this chip
+ */
+struct gpiochip_info {
+     char name[32];
To be pendantic, s/char/__u8/
Thanks, will fix.
Otherwise, looks good, but I don't see the read/write protocol here, is
that in a later patch?
I wanted to get the very basic infrastructure in place first
so we can then add a careful selection of ioctl():s one by
one.

get/set is delicate as I want to be able to handle
reading/switching multiple lines at once from day one as
that reduce context switching nicely, and we also have
.set_multiple() in the driver backend for select chips.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help