Thread (5 messages) 5 messages, 4 authors, 2016-01-28

Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type

From: Linus Walleij <hidden>
Date: 2016-01-27 13:56:14
Also in: lkml

On Wed, Dec 30, 2015 at 3:16 PM, Geliang Tang [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Use irq_data_get_chip_type() instead of container_of().

Signed-off-by: Geliang Tang <redacted>
---
 drivers/gpio/gpio-davinci.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 65ebaef..aaa1a249 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -435,8 +435,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
 {
        static struct irq_chip_type gpio_unbanked;

-       gpio_unbanked = *container_of(irq_get_chip(irq),
-                                     struct irq_chip_type, chip);
+       gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));

        return &gpio_unbanked.chip;
 };
Grygorii/Santosh, can you ACK/comment on this patch?

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help