Thread (3 messages) 3 messages, 3 authors, 2016-01-03

Re: [PATCH v2] i2c: imx: make bus recovery through pinctrl optional

From: Wolfram Sang <hidden>
Date: 2016-01-03 18:30:20
Also in: linux-arm-kernel, linux-i2c, lkml

On Mon, Nov 30, 2015 at 01:55:19PM +0100, Linus Walleij wrote:
On Fri, Nov 20, 2015 at 10:45 PM, Li Yang [off-list ref] wrote:
quoted
-       if (IS_ERR(i2c_imx->pinctrl)) {
+       /* bailout on -ENOMEM or -EPROBE_DEFER, continue for other errors */
+       if (PTR_ERR(i2c_imx->pinctrl) == -ENOMEM ||
+                       PTR_ERR(i2c_imx->pinctrl) == -EPROBE_DEFER) {
This is one of the evils of deferred probe: you never know if
something will eventually turn up. It feels wrong to bail out
on deferred probe...

I have no better idea though.
Acked-by
Linus, proper ack next time please, so patchwork will pick it up
automatically.

Li Yang: There have been some other changes to the imx driver. Could you
rebase against my for-next or for-4.5 and add Linus' ack? Thanks!

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help