Thread (3 messages) 3 messages, 3 authors, 2015-12-10

Re: [PATCH v2] gpiolib: return 0 or 1 in gpiod_get_value*() functions

From: Linus Walleij <hidden>
Date: 2015-12-10 16:54:04
Also in: lkml

On Mon, Nov 30, 2015 at 6:30 PM, Jose Diaz de Grenu de Pedro
[off-list ref] wrote:
Commit 79a9becda894 moved the awareness of active low state
into the gpiod_get_value*() functions, but it only inverts the
GPIO's raw value when it is active low. If the GPIO is active
high, the gpiod_get_value*() functions return the raw value of
the register, which can be any positive value.
No, because:

static int _gpiod_get_raw_value(const struct gpio_desc *desc)
{
        struct gpio_chip        *chip;
        int offset;
        int value;

        chip = desc->chip;
        offset = gpio_chip_hwgpio(desc);
        value = chip->get ? chip->get(chip, offset) : -EIO;
        value = value < 0 ? value : !!value;
        trace_gpio_value(desc_to_gpio(desc), 1, value);
        return value;
}

This returns a negative error code or the value clamped to [0,1]

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help