Re: [PATCH 2/3] pinctrl: nsp: add pinmux driver support for Broadcom NSP SoC

On Mon, Nov 30, 2015 at 6:05 PM, Ray Jui [off-list ref] wrote:

Hi Linus,

On 11/30/2015 4:49 AM, Linus Walleij wrote:

quoted

On Fri, Nov 20, 2015 at 6:57 PM, Yendapally Reddy Dhananjaya Reddy
[off-list ref] wrote:

quoted

This adds the initial support of the Broadcom NSP pinmux driver.

Signed-off-by: Yendapally Reddy Dhananjaya Reddy <redacted>

So what does Ray and Stephen say about this?

Is the hardware unique enough to warrant its own driver?

Or should it utilize/extend one of the existing Broadcom
drivers?

Currently, the IOMUX configurations in Cygnus, NSP, and NS2 are completely
different and require a separate driver to each of these SoCs. We now
realize the shortcomings and have been communicating with our ASIC team.
We'd like to fix this for the next-gen of our SoC. We are driving towards
using a register layout that will allow us to use just "pinctrl-single" and
"pinconf-single."

OK can you provide your reviews for the NSP driver?

Yours,
Linus Walleij