Thread (22 messages) 22 messages, 5 authors, 2015-05-12

Re: [PATCH v2 08/17] gpio: locomo: implement per-pin irq handling

From: Linus Walleij <hidden>
Date: 2015-05-06 14:15:54
Also in: alsa-devel, linux-arm-kernel, linux-fbdev, linux-i2c, linux-input, linux-leds, linux-spi

On Tue, Apr 28, 2015 at 1:55 AM, Dmitry Eremin-Solenikov
[off-list ref] wrote:
LoCoMo has a possibility to generate per-GPIO edge irqs. Support for
that was there in old locomo driver, got 'cleaned up' during old driver
IRQ cascading cleanup and is now reimplemented. It is expected that
SL-5500 (collie) will use locomo gpio irqs for mmc detection irq.

Signed-off-by: Dmitry Eremin-Solenikov <redacted>
Reviewed-by: Linus Walleij <redacted>

Assume this will also go through MFD.
+       irq_set_chained_handler(lg->irq, NULL);
+       irq_set_handler_data(lg->irq, NULL);
Why is this needed? If the GPIOLIB_IRQCHIP code in
gpiolib.c is not doing this then maybe it's the core code that
needs fixing rather than having this in the driver.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help